Craig Shea
My feedback
18 results found
-
1 voteCraig Shea
shared this idea
·
-
104 votesCraig Shea
supported this idea
·
-
3 votesCraig Shea
supported this idea
·
-
45 votesCraig Shea
supported this idea
·
-
2 votesCraig Shea
supported this idea
·
-
9 votesCraig Shea
supported this idea
·
-
2 votesCraig Shea
supported this idea
·
-
1 vote
An error occurred while saving the comment Craig Shea
shared this idea
·
-
10 votesCraig Shea
supported this idea
·
-
6 votes
An error occurred while saving the comment Craig Shea
commented
By far, my number one gripe with the NCrunch Tests window. After all, it is called "NCrunch Tests", so why are non-test projects shown?
Craig Shea
supported this idea
·
-
6 votes
An error occurred while saving the comment Craig Shea
commented
Hmm, what about adding a category to the tests? Then you can sort the Tests window by Category.
-
2 votes
An error occurred while saving the comment Craig Shea
commented
Wow, this would be nice, but not sure it's possible. To do this, it would need to most likely rely on a lot of internal behavior of Nunit, which could change at any time. And since NCrunch is really test framework agnostic, it really doesn't want to take a dependency on internal test framework behavior.
But I hear you, this would be really nice if it were possible.
-
153 votesCraig Shea
supported this idea
·
An error occurred while saving the comment Craig Shea
commented
This would be a welcome addition, but one which would take quite a bit of work, I'm sure. I would love to use VS Code more, especially for F# development, and it would be awesome to have a first-class continuous test runner such as NCrunch in that environment.
-
7 votesCraig Shea
supported this idea
·
An error occurred while saving the comment Craig Shea
commented
Yes, this is an awesome suggestion.
-
59 votes
An error occurred while saving the comment Craig Shea
commented
So, the CodeLens statistics you're seeing are for "integrated" unit test frameworks, e.g. NUnit, MSTest, xUnit, which use the VS Test Runner. Since NCrunch is using its own runner which does not integrate with the VS Test Runner itself, it does not update the "out of the box" CodeLens.
However, this does not necessarily negate the ability for NCrunch to be able to supply its own CodeLens--though, I'm not sure that it's really needed since this information is already provided in the markers shown to the left of covered code.
-
2 votes
An error occurred while saving the comment Craig Shea
commented
I second this. We have some unit tests that emit a string giving more context around what may be wrong, and we use, for example, `$"{System.Environment.NewLine}Expected controller action method {actionMethod} to be decorated with the permission {permission}"; The `System.Environment.NewLine` gets output as `\r\n` in the NCrunch window, which completely ruins the formatting of the messages.
-
45 votes
An error occurred while saving the comment Craig Shea
commented
Not to push people away from NCrunch, but Resharper and VS Live Unit Testing do exactly this: only runs tests on save of a file. This is what they call "continuous" testing. Well, it's not continuous testing.
In fact, it's this behavior of only running tests upon saving a file which drives people to use NCrunch in the first place!! I work in a solution with 20K tests (9.5K of these are in one test project alone!) and I do not have any issues using NCrunch.
The biggest reason why you would typically encounter issues using NCrunch is due to not tuning NCrunch correctly for your particular solution. The next biggest reason that NCrunch may not work well is due to something in your configuration/environment/solution which is not considered a "good practice". And finally, the third issue you would encounter with NCrunch are tests which are not well written nor following good unit/isolation testing principles, such as the FIRST principles.
Given all of the above, I see no need to implement such a capability.
-
4 votesCraig Shea
supported this idea
·
Also, the brace construct would allow you to reduce the number of explicit inclusions you need to create, for example:
..\**\*.cs{,proj}
would match all *.cs files and *.csproj files.